Use NOT VALID to enforce a NOT NULL constraint on file_store to ci_job_artifacts, lsf_objects and uploads tables
What does this MR do?
Part of #213382 (closed), this MR uses NOT VALID to enforce a NOT NULL constraint on file_store column to ci_job_artifacts, lsf_objects and uploads tables When adding a constraint to a table, we can optionally include NOT VALID. This tells Postgres that it doesn’t need to enforce the constraint on existing records in the table. At least not immediately. This constraint will be enforced for any updates and subsequent insertions. Thus, we can immediately enforce the constraint while giving ourselves time to clean up any existing records that conflict with the constraint.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team