Skip to content

Update doc to add migration output for up and down

Alper Akgun requested to merge add-migration-output-for-up-and-down into master

What does this MR do?

What does this MR do?

Update database review guidelines to ask the addition of the up and down methods of all migrations into the MR description

  1. Adding the output for both up and down ensures the author runs the migrations (again) and sees the effect and reviewer can verify it.
  2. Adding the down output ensures we see and test the db/structure.sql is modified !28029 (merged)
  3. Keeping the migration up-to-date is emphasized

Author's checklist

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • [-] Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. [-] If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by 🤖 GitLab Bot 🤖

Merge request reports