Skip to content

Fix duplicated tag deletion activity and events

Sashi requested to merge (removed):sk/fix-tag-deletion-duplicate-events into master

What does this MR do?

This MR fixes Issue #212969 (closed)

When a release tag is deleted, it creates double activity entries and also double webhook/service notifications if the project is configured with webhook/service integrations.

Currently, this is what happens when a tag is deleted:

  • Tags::DestroyService calls repository.rm_tag and calls project hooks and executes events. Call to rm_tag invokes Gitaly UserDeleteTagRequest
  • Gitaly posts back to /internal/post_receive API which invokes PostReceive worker
  • PostReceive worker invokes TagHooksService which calls the same hooks/services again

This MR removes the project hooks and services call in Tags::DestroyService which is no longer needed.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sashi

Merge request reports