Monitoring dashboard chart tooltip improvements
What does this MR do?
When a deployment icon is hovered the deployment details (sha, commit URL) are fetched by looking up the array of deployments object based on the x-axis value. This iteration and lookup can be avoided if the details are passed as data
object to eCharts. On hover, echarts provides access to all values and custom data passed.
This MR removes the lookup and passes all required deployment metadata to eCharts.
Eventually, deployments and annotations will be consolidated so this MR will make the process easier.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖