Move deployment series logic out of charts
What does this MR do?
- Adds annotations.js file to move the deployment series logic out of the charts to avoid bloating the chart component.
- Eventually, annotations (new feature) and deployments will coexist in the same series.
- This MR does not change the current deployments behaviour.
Background
The deployment series generation logic currently exists inside the TimeSeries chart component. With the introduction of annotation features (annotation lines), which functions similarly to the deployment series, the series generation logic needs to be more flexible. Hence moving it out to its own file.
Deployment series is a scatter plot series with deployment rocket icons, which is passed along with the actual chart data. Think of it as a decoration layer on top of the data.
Screenshots
This is how the deployment series generated icons looks like.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖