Enable the `release_asset_link_editing` feature flag by default
What does this MR do?
Updates the release_asset_link_editing
feature flag to be enabled by default.
This feature flags hides the "asset link" editing section of the Edit Release page that is being implemented in #9427 (closed):
Related to #9427 (closed)
Merge request reports
Activity
changed milestone to %12.10
added Category:Release Orchestration Deliverable Dogfooding DogfoodingBuild in GitLab Enterprise Edition GitLab Ultimate Product Vision FY20 UX cicdactive devopsrelease [DEPRECATED] direction frontend internal customer maturitycomplete missed-deliverable missed:12.9 typefeature workflowin review + 1 deleted label
assigned to @nfriend
added 1 commit
- fc86fda7 - Enable the `release_asset_link_editing` flag
mentioned in merge request !28493 (merged)
1 Warning You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Alishan 'Ali' Ladhani ( @ali-gitlab
)James Lopez ( @jameslopez
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 290 commits
-
fc86fda7...e990cfc6 - 289 commits from branch
master
- ebc880cc - Enable the `release_asset_link_editing` flag
-
fc86fda7...e990cfc6 - 289 commits from branch
@markrian This MR just enables the feature finished in !28493 (merged) by default. Would you mind reviewing/merging?
assigned to @markrian
Technically this is backend, but clearly this is so trivial I think we'll be fine
LGTM!
mentioned in commit a661d092
mentioned in merge request gitlab-com/www-gitlab-com!41001 (merged)
added Pick into auto-deploy label
@nfriend This merge request could not automatically be picked into
12-10-auto-deploy-20200415
for12.10.0-ee
:- Merge request does not have S1 or S2 label
This requires manual intervention.
Please refer to GitLab.com releases
Can we add an S2 @nfriend?
@jmeshell I don't think so - not without bending the definition of ~S2 quite a bit.
~S2 is reserved for ~"bug"s that meet the definition of "critical" described here: https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity
You are right @nfriend
removed Pick into auto-deploy label
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !44008 (merged)
mentioned in commit davebarr/gitlab@509c00a1
mentioned in commit 820f7979