Skip to content

WIP: Support pattern matching in ServiceResponse

Alex Kalderimis requested to merge ajk-service-response-pattern-matching into master

What does this MR do?

This MR adds pattern matching support for ServiceResponses. There are two aspects to this: subclasses to support dispatching on class, and deconstruct_keys to support binding instance fields.

The concrete case is to be able to do the following:

case service.execute
in ServiceResponse::Success(payload: { thing: x })
  do_something_with(x)
in ServiceResponse::Error(message: msg)
  oh_no!(msg)
end

i.e. pattern matching is much more useful when using it to branch and bind at the same time.

Without the subclasses, but making use of deconstruct_keys, the following syntax is also available:

case service.execute
in { state: :success, payload: { thing: x } }
  do_something_with(x)
in { state: :error, message: msg }
  oh_no!(msg)
end

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports