Skip to content

Return ServiceResponse from Alert::NotifyService

What does this MR do?

Unify return type for Projects::Alerting::NotifyService and Projects::Prometheus::Alerts::NotifyService

Side effect: Extends the list of response statuses for Prometheus alerts notifications endpoint.

Before:

Responses: :ok, and :unprocessable_entity

After:

Responses: :ok, :unprocessable_entity, :bad_request, and :unauthorized


Contributes to #212294

Helps extract similar shared examples for these classes. Therefore contributes to #212412 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] ~~Label as security and @ mention @gitlab-com/gl-security/appsec~~
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports