Skip to content

Add worker label to Sidekiq prometheus metrics

Oswaldo Ferreira requested to merge osw-add-worker-label-to-prom into master

What does this MR do?

As part of the work to reduce the amount of queues Sidekiq has to listen to, here we introduce a worker label that will provide enough information to query metrics per worker.

Today it's not strictly required given we have an one-queue-per-worker approach (so we're able to know which worker is causing issues through its queue name), though it'll change soon.

gitlab-com/gl-infra/scalability#231 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Oswaldo Ferreira

Merge request reports