Skip to content

Add finders for group-level runners and jobs

Arthur de Lapertosa Lisboa requested to merge ciandt_dev/gitlab:add-finders-group-runners-jobs into master

What does this MR do?

As part of the effort to implement the changes proposed by #37366 (closed), I understand two new finders are required to fill a gap when managing Runners and Jobs on the group level. The goal of this MR is to add GroupJobsFinder and GroupRunnersFinder, that will get all jobs and runners related to a given group.

  • Regarding the GroupJobsFinder, it’ll get all jobs belonging to projects within a given group. The jobs can also be filtered by scope, if a params object is passed along with the call of the execute method.
  • Regarding the GroupRunnersFinder, it’ll get all runners belonging to projects within a given group and all runners that belong to the group itself. Important to notice that according to the discussion on the issue thread, the finder does not get the shared/instance runners.

This is the very first MR to address the issue and will be followed by more MRs addressing controller and view changes.

Are there points in the code the reviewer needs to double check?

No, they follow the existing finders structure.

Does this MR meet the acceptance criteria?

  • Documentation created/updated - N/A
  • Added tests for this feature/bug
  • In case of conflicts with master - no conflicts

What are the relevant issue numbers?

#37366 (closed)

Edited by Arthur de Lapertosa Lisboa

Merge request reports