Fix release api milestone not found
What does this MR do?
This MR fixes the bug in Release API: #37266 (closed)
When a Release is to be updated with a Group Milestone, it returned the error Milestone not found. This was due to a missing parameter in MilestoneFinder, which is called by ReleaseUpdater. It missed the param group_ids. After this fix, an extra validation was necessary to set up in MilestoneRelease model. It only checked wether the milestone and the release is in the same group. In our case, this check is replaced wether the milestone's group is the same as the release's projects's group.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team