Move tasks by type components into separate directory
requested to merge 197337-value-stream-analytics-move-type-of-work-charts-to-separate-module into master
What does this MR do?
First MR for refactoring the tasks by type chart compoennt &2434 (closed), follow up MRs will move the vuex code into a separate module and clean up related specs.
- Un-nests the
tasks_by_type_filter
from thetasks_by_type_chart
component, which ensures filters can be updated even if there are no results available - Updated specs
- Fixes the flash of
no data available
when the top ranked labels request completes but the tasks by type chart data request is still pending - Ensures we clear the tasks by type data when a filter is updated
- Groups the tasks by type components in the
type_of_work
component giving a clear place to mount the vuex data which will be moved to a module in a future MR. Additionally, provides a space for the [tasks by stage feature[(&1980 (closed))
Screenshots
Requires :tasks_by_type_chart
feature flag
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #197337 (closed)
Edited by 🤖 GitLab Bot 🤖