Skip to content

Allow users to assign a serverless domain to Knative (frontend)

Mike Greiling requested to merge mg-add-knative-domain-dropdown into master

What does this MR do?

Adds a dropdown selector to allow instance-level serverless domains to be associated with a Knative app.

This is the frontend component of !21436 (merged) (part of #35591 (closed))

Screenshots

dropdown default state dropdown open
Screen_Shot_2020-03-31_at_7.15.35_AM Screen_Shot_2020-03-31_at_7.15.42_AM
dropdown filtered dropdown selected
Screen_Shot_2020-03-31_at_7.15.52_AM Screen_Shot_2020-03-31_at_7.16.12_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports