Fetch annotations for monitoring dashboard
What does this MR do?
This MR fetches annotations data and passes it to the Area and line charts. Annotations fetch backend API isn't ready yet #211330 (closed) but this MR can't be delayed further if this has to be delivered for %12.10.
To make sure things don't break, the changes are behind metrics_dashboard_annotations feature flag.
Notes
- This MR is behind FF and does not change any UI elements.
- The failing rspecs are not related to this MR.
Why no UX review?
- The initial annotations feature that went into GitLab UI was already approved by UX gitlab-ui!1232 (merged) and this MR merely just passed on the annotations data to the GitLab UI charts.
- This MR doesn't change anything in the UI. The upcoming MR to lift the feature flag will one more additional UX approval before the feature goes in.
Is this the final MR?
- No. Also, you'll notice from the gif below that the annotation interaction is not convenient. I have a GitLab UI MR to make it more intuitive and convenient gitlab-ui!1288 (merged).
- There will be another to lift the feature flag.
Screenshots
| header | header |
|---|---|
| Screenshot |  |
| Gif |  |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Mentions #211418 (closed)
Edited by 🤖 GitLab Bot 🤖