Skip to content

Refactor FilterableArrayConnection to use newer Graphql::Pagination class

Brett Walker requested to merge bw-refactor-filterablearrayconnection into master

What does this MR do?

Make FilterableArrayConnection inherit from GraphQL::Pagination::ArrayConnection instead of GraphQL::Relay::ArrayConnection. This new support was made available in graphql 1.10

Also moved the FilterableArrayConnection into lib/gitlab/graphql/pagination directory

Relates to #211607 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports