Skip to content

Enable log explorer to use the full height of the screen

What does this MR do?

Fix for #210502 (closed) and #211507 (closed)

Previously a hardcoded height for the log explorer was set to 600px, in large screens this was too small, and it should adjust in larger (and smaller) screens.

Roughly based on how the issue board keeps and adjustable screen height, with an additional using some flex-column to complete the effect and stretch the logs viewer along with the screen.

Screenshots

Large screens (uses full height)

2020-04-03_18.18.38

large (15") xl (27")
image image

Small screens (when scrolling inside the page is still needed)

2020-04-03_18.25.23

Technical Notes

Why move to <gl-alert>?

For this layout to work in different screen sizes, we must know the height of the elements above the logs viewer container. The header and breadcrumb must have a known height.

For this reason, flash() was replaced with <gl-alert> so can be placed inside the logs viewer container. The dismiss action imitates the behavior of flash(), so no significant UX changes are expected.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #210502 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports