Support single- or multiple-token deletion via backspace keyboard combinations in search inputs
What does this MR do?
This feature allows users to delete tokens in search inputs via standard macOS/Windows keyboard shortcuts.
Using ⌥ (Mac) / Ctrl + ⌫ will delete token-by-token, beginning with the last entered token, or current input value if there is any value following the last entered token.
Using ⌘ (Mac) + ⌫ will delete all tokens.
In case multiple meta-keys are depressed (for instance, ⌘ and ⌥), single-token deletion is preferred.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
This change poses no known risks.
This change has been tested on macOS 10.14.6 in the following browsers:
-
Chrome 80.0.3987.149 -
Safari 13.0.3 -
Firefox 74.0 -
Edge 80.0.361.69 -
Internet Explorer 11.x
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
I have added tests to existing Karma specs in accordance with https://docs.gitlab.com/ee/development/testing_guide/frontend_testing.html.
Security
This MR does not contain changes to processing or storing of credentials or tokens, authorization or authentication methods or any other items described in the security review guidelines.