Skip to content

Prevent adding changelog ID on security MRs

Mayra Cabrera requested to merge prevent-changelog-id-on-security-mrs into master

What does this MR do?

95c0aa51 introduced a new conditional on changelog Dangerfile that is triggered on security MRs. On security merge requests, it's not necessary to add a merge_request ID on the changelog file, so this MR fixes that.

Reported on https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/387#note_313052314

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports