Skip to content

Clean code: Refactor and improve code related to services

Arturo Herrero requested to merge service-clean-up into master

What does this MR do?

I'm reviewing, refactoring and improving the code related to services. The best way to review the changes is by reviewing each commit separately 😉

The last commit also fixes the visibility of disabled project services related to Slack because we were not listing the disabled project services but we were able to edit the individual service if we know the valid URL. This commit fixes that discrepancy between index and show/edit actions.

Eg, on GitLab.com I can see the list of Slack available services, hovering the mouse shows these two URLs:

But I'm also able to navigate to:

List all available services Edit not visible service
Screen_Shot_2020-03-30_at_09.37.18 Screen_Shot_2020-03-30_at_09.39.48

This is part of the work related to #199388 (closed).

Edited by 🤖 GitLab Bot 🤖

Merge request reports