Skip to content

Migrate frontend note specs from karma to jest

Lukas 'ai-pi' Eipert requested to merge leipert-jestodus-take-23 into master

What does this MR do?

  • We are migrating all specs in javascripts/notes to frontend/notes

Also we fixed a minor bug:

Remove unnecessary API call for image diffs

Apparently we are trying to retrieve truncated diff lines on image diffs, which doesn't make any sense. The migrated test actually catched this error, so we are going to add another check.

Preferably we could move the text diff into a sub component.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas 'ai-pi' Eipert

Merge request reports