Skip to content

Expose test reports with attachment on pipeline

Max Orefice requested to merge mo-return-test-report-with-attachment into master

Part of #202114 (closed)

This feature is behind the junit_pipeline_screenshots_view feature flag (attachment_url).

What does this MR do?

Following up !27839 (merged) where we added filtering for a test report by attachment.

This MR modify our existing test_report.json endpoint by introducing a new URL param which will filter only our test reports containing attachments.

endpoint scope
pipelines/60/test_report.json with_attachment

This will allow frontend to request the data required in order to build the following page:

Screenshot page
image

Today's problem

It's not currently possible to filter out our TestReport. We are working on making possible to link a screenshot for a given test failure.

Today, if a failure happens we need to inspect the job artifacts manually in order to retrieve a given screenshot which takes time for us internally.

Solution

We want to make it simple for the user to display a screenshot associated to a test failure. This way we can show a failing screenshot on a pipeline without browsing all the job artifacts manually.

Check the design for this feature.

Screenshots

Test report without attachment Test report with attachment
Mozilla_Firefox_2020-03-25_16-25-29 Mozilla_Firefox_2020-03-25_16-25-44

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports