Skip to content

Refactor compare analyser reports service tests

Can Eldem requested to merge refactor-compare-analyser-service-tests into master

What does this MR do?

Refactor compare analyser reports service tests for reducing database interactions

before

{{............................[TEST PROF INFO] EventProf results for sql.active_record

Total time: 00:08.773 of 00:21.793 (40.26%)
Total events: 8826

Top 5 slowest suites (by time):

Ci::CompareSastReportsService (./ee/spec/services/ci/compare_sast_reports_service_spec.rb:5) – 00:02.716 (3130 / 6) of 00:07.913 (34.33%)
Ci::CompareCo...ReportsService (./ee/spec/services/ci/compare_container_scanning_reports_service_spec.rb:5) – 00:02.124 (1873 / 8) of 00:04.542 (46.78%)
Ci::CompareDastReportsService (./ee/spec/services/ci/compare_dast_reports_service_spec.rb:5) – 00:01.992 (2145 / 6) of 00:05.013 (39.74%)
Ci::CompareDe...ReportsService (./ee/spec/services/ci/compare_dependency_scanning_reports_service_spec.rb:5) – 00:01.939 (1678 / 8) of 00:04.324 (44.85%)

after

..........................[TEST PROF INFO] EventProf results for sql.active_record

Total time: 00:04.925 of 00:12.770 (38.57%)
Total events: 5004

Top 5 slowest suites (by time):

Ci::CompareDe...ReportsService (./ee/spec/services/ci/compare_dependency_scanning_reports_service_spec.rb:5) – 00:01.526 (1255 / 8) of 00:03.356 (45.48%)
Ci::CompareSastReportsService (./ee/spec/services/ci/compare_sast_reports_service_spec.rb:5) – 00:01.486 (1541 / 6) of 00:04.261 (34.89%)
Ci::CompareCo...ReportsService (./ee/spec/services/ci/compare_container_scanning_reports_service_spec.rb:5) – 00:00.993 (1106 / 6) of 00:02.290 (43.36%)
Ci::CompareDastReportsService (./ee/spec/services/ci/compare_dast_reports_service_spec.rb:5) – 00:00.918 (1102 / 6) of 00:02.861 (32.08%)
}}

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Merge request reports