Skip to content

Refactor compare license scanning reports service test

Can Eldem requested to merge refactor-compare-license-test into master

What does this MR do?

Just small experiment for reducing active_record interactions. 1236 -> 977

before

{{.......[TEST PROF INFO] EventProf results for sql.active_record

Total time: 00:01.696 of 00:03.329 (50.96%)
Total events: 1236

Top 5 slowest suites (by time):

Ci::CompareLi...ReportsService (./ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb:5) – 00:01.696 (1236 / 7) of 00:03.329 (50.96%)

after

.......[TEST PROF INFO] EventProf results for sql.active_record

Total time: 00:01.258 of 00:02.878 (43.71%)
Total events: 977

Top 5 slowest suites (by time):

Ci::CompareLi...ReportsService (./ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb:5) – 00:01.258 (977 / 7) of 00:02.878 (43.71%)
}}

Conformity

Merge request reports