Skip to content

Support more types in UrlBuilder

Markus Koller requested to merge url-builder-refactor into master

What does this MR do?

This was extracted from !27428 (merged), and allows us to use Gitlab::UrlBuilder in more places.

  • Add support for projects and groups.
  • Add support for building path-only URLs.
  • Reuse it in HasRepository#web_url.
  • Remove state and turn the class into a singleton.
  • Provide a default instance in presenters.
  • Rewrite specs with parameterized table syntax.

The tweaks to the factories were extracted into !28778 (merged).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports