Make alert widget loading state optional
What does this MR do?
The second iteration for the dashboard refresh button #207549 (closed) requires the chart panel to have its own loading spinner. This MR makes the alert widget's loading spinner optional (true by default) so that it can be hidden once the chart panel has its own loading spinner.
Why not completely remove loading spinner?
The loading state is not completely removed so that this widget can still be used in other places if required.
Why consolidate?
The rationale behind consolidating the loading spinners is here &2702 (comment 308764439)
Note The alert widget's loading state is visible by default so there is no UI change for now.
Screenshots
| Current | This is how no loading state would look like (Imagine this together with the below image) |
|---|---|
 |
 |
This is how the chart loading state would look like
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Mentions #207549