Skip to content

Include LDAP UID attr in default attrs for LDAP lookups

Drew Blessing requested to merge dblessing-ldap-username-uid-fix into master

What does this MR do?

Fixes #212465 (closed)

In cases where the configured LDAP uid attribute is non-standard (not uid, samaccountname, userid) the username value in the LDAP auth hash will not contain a value. By including the configured uid attribute in the username default attributes array we ensure that the value will be present in the auth hash.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports