Resolve "Group Activity Analytics: Add New Members count"
What does this MR do?
We recently implemented !26285 (merged) to display the following metrics in the Group Activity
card:
Merge Requests created
Issues created
This MR adds the New Members created
metric to the group activity card.
This is behind the group_activity_analytics
feature flag.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #212433 (closed)
Merge request reports
Activity
changed milestone to %12.10
added devopsfoundations frontend groupoptimize typefeature workflowblocked labels
mentioned in merge request !28017 (merged)
assigned to @wortschi
1 Warning ⚠ The merge request title length is acceptable, but please try to reduce it to 50 characters.. For more information, take a look at our Commit message guidelines. 1 Message 📖 CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 28093 "Resolve "Group Activity Analytics: Add New Members count""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 28093 "Resolve "Group Activity Analytics: Add New Members count""
Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Nick Kipling ( @nkipling
)Mark Florian ( @markrian
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added 2 commits
added 314 commits
-
27bc6d4d...facf9e0f - 311 commits from branch
master
- 3a0bbc4f - Add groupActivityNewMembersCount to API
- 45ebc551 - Add metric to group activity card
- 5bbcca12 - Update PO file
Toggle commit list-
27bc6d4d...facf9e0f - 311 commits from branch
mentioned in issue #207164 (closed)
added 442 commits
-
5bbcca12...fc4b8356 - 439 commits from branch
master
- cd5d2862 - Add groupActivityNewMembersCount to API
- b7df8244 - Add metric to group activity card
- 9459adfa - Update PO file
Toggle commit list-
5bbcca12...fc4b8356 - 439 commits from branch
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed