Skip to content

Fix project controller event feed

André Hänsel requested to merge AndreKR/gitlab:fix-project-controller-event-feed into master

The ProjectsController currently loads a list of projects the user has access to in the function load_projects. It uses this list to render the actual list of projects, but it also uses this list to render the activity feed in the atom form for the RSS feed.

The problem is that load_projects already paginates the list of projects which leads to wrong results (only the first 20 projects are considered) when rendering the RSS feed.

The error was intruduced in 837c3b3d, so this commit partially reverts the changes made in that commit, moving the pagination back out of load_projects and into the respective routes.

Note: There was an alternative solution in !19523 (closed) but we decided to use this one because it seems to fit better with the principle of the least surprise.

Note: This was previously implemented in !19524 (merged) but had to be reverted in !26965 (merged) because of an unwanted side effect that has been fixed in this version.

Fixes #24227 (closed) Fixes #29990 (closed)

Merge request reports