Skip to content

Improve SAST NO_DIND file detection with proper boundary conditions

What does this MR do?

Improves SAST NO_DIND file detection with proper regex word boundary conditions.

This MR fixes 2 bugs:

  • word boundaries were missing in many regexes, ensuring things like deruby (totally made up language) isn't detected as "ruby"
  • Fix regex for identifying c and c++ distinct from c#, which is detected by a different analyzer: https://regex101.com/r/FiENMK/1

Relates to #197958 (closed)

Screenshots

Screen_Shot_2020-03-27_at_3.01.26_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lucas Charles

Merge request reports