Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 38,035
    • Issues 38,035
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,345
    • Merge requests 1,345
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !28023

Merged
Created Mar 25, 2020 by Dan Davison@ddavisonMaintainer4 of 4 tasks completed4/4 tasks

Resolve "Impossible to remove orphan artifact files"

  • Overview 6
  • Commits 2
  • Pipelines 4
  • Changes 3

What does this MR do?

Changes an invalid --class option passed to ionice to use -c instead.

According to the ionice man-pages ...

-c class The scheduling class. 0 for none, 1 for real time, 2 for best-effort, 3 for idle.

We already use the correct -c option elsewhere in our code here and here.

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • [-] Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content

Availability and Testing

Tests are already written for orphan_job_artifact_files.rb but there clearly exists a gap in testing if this was not caught.

Closes #211950 (closed)

Edited Mar 25, 2020 by Dan Davison
Assignee
Assign to
Reviewer
Request review from
12.10
Milestone
12.10 (Past due)
Assign milestone
Time tracking
Source branch: 211950-impossible-to-remove-orphan-artifact-files