Old - Eliminate group_level_cycle_analytics FF
What does this MR do?
This MR removes the group_level_cycle_analytics
feature flag. The feature flag was already default enabled in 12.10.
Additional change: copy VSA (cycle_analytics) controllers to groups
namespace and update the URLs on the FE side. Basically we have two controllers with the same functionality (duplication). Tests are also duplicated for now.
Reasoning: During deployment the user might load the old frontend code which references the old URLs. If the old URLs are no longer working with the new version of gitlab, then the feature would be broken for the users (404 errors). The old, duplicated code will be cleaned up in the next milestone (13.0).
I was thinking about extracting the common parts and reuse them at both places (/analytics/value_stream_analytics and /groups/-/analytics/value_stream_analytics), however it's extra work and we know for sure that /analytics/value_stream_analytics will go away.
Additional changes:
ee/app/controllers/groups/cycle_analytics/events_controller.rb
ee/app/controllers/groups/cycle_analytics_controller.rb
Both controllers are using the old CA backend, which is not in use since 12.8. Safe to remove.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #212226 (closed)