Publish status page on note changes
What does this MR do?
Part of #205168 (closed). Contributes to #205167 (closed).
This MR hooks into the update and deletion services of a note to trigger a status page update.
Note: We are not hooking into the creation service because we only publish notes with
The next MR will hook into award creation/deletion of
Action | Publish to Status Page |
---|---|
Create note on issue |
|
Update note on issue with |
|
Update note on issue without |
|
Delete note on issue with/without |
|
Update system note on issue with |
|
Notes on e.g. merge requests |
This MR is behind a beta feature flag and we tracking the rollout in #210026 (closed) hence also the missing changelog entry.
Screencasts
Add/modify/delete note |
---|
database query plans
Parameters used for these plans:
-
note_id: 308363797
- #207181 (comment 308363797)
note.award_emoji.named(StatusPage::AWARD_EMOJI).none?
Click to expand
Query:
SELECT 1 AS one
FROM "award_emoji"
WHERE "award_emoji"."awardable_id" = 308363797 AND "award_emoji"."awardable_type" = 'Note' AND "award_emoji"."name" = 'microphone'
LIMIT 1
Plan: https://explain.depesz.com/s/2nCi
✅ Looks good
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team