Skip to content

Publish status page on note changes

Peter Leitzen requested to merge pl-status-page-mvc-changes-notes into master

What does this MR do?

Part of #205168 (closed). Contributes to #205167 (closed).

This MR hooks into the update and deletion services of a note to trigger a status page update.

Note: We are not hooking into the creation service because we only publish notes with 🎤 and we cannot add an emoji during its creation.

The next MR will hook into award creation/deletion of 🎤 emoji.

Action Publish to Status Page
Create note on issue 🚫 (no 🎤 set)
Update note on issue with 🎤
Update note on issue without 🎤 🚫
Delete note on issue with/without 🎤
Update system note on issue with 🎤 🚫
Notes on e.g. merge requests 🚫

This MR is behind a beta feature flag and we tracking the rollout in #210026 (closed) hence also the missing changelog entry.

Screencasts

Add/modify/delete note
status-page-note

database query plans

All SQL queries below will be executed in a background job and not during a web request.

Parameters used for these plans:

note.award_emoji.named(StatusPage::AWARD_EMOJI).none?

Click to expand

Query:

SELECT 1 AS one
  FROM "award_emoji"
  WHERE "award_emoji"."awardable_id" = 308363797 AND "award_emoji"."awardable_type" = 'Note' AND "award_emoji"."name" = 'microphone'
LIMIT 1

Plan: https://explain.depesz.com/s/2nCi

Recommendations:

Looks good

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports