Skip to content

Enable placeholders for broadcast notifications

Nicolas Dular requested to merge nicolasdular/broadcast-placeholders-ff into master

What does this MR do?

Part of #211369 (closed)

This removes the feature flag for broadcast placeholders and only enables placeholders for notifications. This feature flag changes the logic intentionally. During initial development it came apparent that placeholders only make sense for notifications, but this was then not reflected in the final MR.

This MR fixes this, removes the feature flag, adds a test for the new code path and cleans up the specs.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nick Thomas

Merge request reports