Skip to content

Use Gitlab::HTTP.try_get to find commit_status from Bamboo CI

What does this MR do?

!27395 (merged) introduced the try_get method for Gitlab::HTTP to handle common errors.

#29825 (closed) is about TeamcityService, but BambooService uses ReactiveCaching as well, so this MR refactors the BambooService to use try_get.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports