Update language detection for SAST NO_DIND spotbugs coverage
What does this MR do?
Fixes bug in spotbugs analyzer's language detection. Before this fix the target languages of scala
and groovy
were excluded for SAST scans when using SAST_DISABLE_DIND
mode. This MR realigns the detection logic with spotbugs plugin detection logic.
Fixes #119092 (closed)
Groovy
NOTE: We could not use the standard tests/java-groovy
project since it includes Java and we wanted to test a pure-groovy detection
- [BEFORE]
❌ Pipeline for groovy test project failing to run analyzer: https://gitlab.com/theoretick/java-groovy/pipelines/128974014 - [AFTER]
✅ Pipeline for groovy test project correctly running analyzer: https://gitlab.com/theoretick/java-groovy/pipelines/128974149
Scala
- [BEFORE]
❌ Pipeline for scala test project failing to run analyzer: https://gitlab.com/gitlab-org/security-products/tests/scala-sbt/pipelines/128972520 - [AFTER]
✅ Pipeline for scala test project correctly running analyzer: https://gitlab.com/gitlab-org/security-products/tests/scala-sbt/pipelines/128972726
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Lucas Charles