Skip to content

PyPi: Support package installation

Giorgenes Gelatti requested to merge 208747-pypi-package-installation into master

What does this MR do?

Adds support for PyPi package installation via the pip command.

Caveats

Installing packages through pip requires 2 API calls: one to list the package versions and a second to download the actual package file.

The former supports token authentication but the latter doesn't. pip doesn't pass along the credentials to the download endpoint.

For this reason the download endpoint has been make public with the sha256 of the file included in the url so the filename can't be guessed. Only the authorized requests get to know the list of file names.

The alternative to this would be to return these urls to the client with the token in it but I think the security risk is the same or worse.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #208747 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports