Skip to content

Add atomic and cleanup-on-fail parameters

Zamir Martins requested to merge add_helm_params_rollback_related into master

What does this MR do?

To help when dealing with upgrades and failed states in Helm.

Example:

helm upgrade ingress stable/nginx-ingress --install --atomic --cleanup-on-fail --reset-values --tls \
--tls-ca-cert /data/helm/ingress/config/ca.pem --tls-cert /data/helm/ingress/config/cert.pem  \ 
--tls-key /data/helm/ingress/config/key.pem --version 1.29.7 \
--set 'rbac.create=true,rbac.enabled=true' --namespace gitlab-managed-apps \
-f /data/helm/ingress/config/values.yaml

cleanup-on-fail is supported since: https://github.com/helm/helm/releases/tag/v2.14.0

atomic is supported since: https://github.com/helm/helm/releases/tag/v2.13.0

It came as an investigation of #211758 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zamir Martins

Merge request reports