Skip to content

Highlight currently focused/viewed file in file tree

David O'Regan requested to merge 24629 into master

What does this MR do?

This MR is based on issue #24629 (closed)

It can be considered a utterly MVC to get this update underway. The merge attempts to get the ball rolling for the change with a method that removes the highlighted class when the file name has been clicked based on the previous work done here: gitlab-foss!29030 (closed)

Further work needed:

  • Update file tree via the IntersectionObserver API as suggested here: gitlab-foss!29030 (comment 177129131)
  • Finish removing CSS from the file_row.vue component in favour of more utility classes! This though can be a follow up 😄

Screenshots

No Files Clicked Some files clicked All files clicked
Screenshot_2020-03-20_at_17.45.15 Screenshot_2020-03-20_at_17.45.22 Screenshot_2020-03-20_at_17.45.28

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports