Geo - Update Verification Popover
What does this MR do?
Closes #209262 (closed)
There is currently an overall effort of making the Geo Admin screen more intuitive.
This MR focuses on the Geo Node Verification Information. We have gotten feedback that the information is repetitive on every verification item. Instead we decided to move the popover information to the tab itself, and thus require to only have one popover for all verification information on each node.
How:
- Remove old legacy code for popover
- Remove props that passed down popover info to each sync item
- Use
GlPopover
on the Verification Tab itself
Screenshots
Verification Info | |
---|---|
before | ![]() |
onPrimary | ![]() |
onSecondary | ![]() |
GIF
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #209262 (closed) cc @sunjungp
Edited by Zack Cuddy