Skip to content

Geo - Update Verification Popover

Zack Cuddy requested to merge 209262-geo-verification-popovers into master

What does this MR do?

Closes #209262 (closed)

There is currently an overall effort of making the Geo Admin screen more intuitive.

This MR focuses on the Geo Node Verification Information. We have gotten feedback that the information is repetitive on every verification item. Instead we decided to move the popover information to the tab itself, and thus require to only have one popover for all verification information on each node.

How:

  • Remove old legacy code for popover
  • Remove props that passed down popover info to each sync item
  • Use GlPopover on the Verification Tab itself

Screenshots

Verification Info
before Screen_Shot_2020-03-19_at_2.06.55_PM
onPrimary From_Primary
onSecondary From_Secondary

GIF

More information link More_Information

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #209262 (closed) cc @sunjungp

Edited by Zack Cuddy

Merge request reports