Skip to content

Refactor CloneDashboardService to remove catch/throw

Kirstie Cook requested to merge refactor-clone-dashboard-service into master

What does this MR do?

Recently refactored UpdateDashboardService in !27185 (merged) which is extremely similar to CloneDashboardService, so while it was still fresh on the mind I decided to implement the same thing here. This will make it easier to extract the shared behavior between the two services, and also no longer violates the ban on catch/throw.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports