Skip to content

Move Gitlab Employee badge to internal discussion api

Aishwarya Subramanian requested to merge fix-gitlab-employee-attribute into master

What does this MR do?

The is_gitlab_employee attribute in the MR was incorrectly added to the discussion api, instead of internal discussion api.

This MR adds the attribute appropriately.

The attribute is added to the NoteUserEntity serializer, which isn't used in many places and therefore not cause any performance degradation.

Closes #211847 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Aishwarya Subramanian

Merge request reports