Skip to content

Fix for empty keys on Redis#del

Robert May requested to merge fix-for-set-cache-deletions into master

What does this MR do?

The Repository model can provide an empty array of methods for which to delete the caches (. I missed that this was a possibility in the original implementation :\

The cause: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/repository.rb#L314

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports