Skip to content

Protect against nil metric identifier

Ryan Cobb requested to merge 207457-fix-multi-metrics-panels into master

What does this MR do?

This fixes #207457 (closed). Multiple metric panels were not displaying all metrics because the find_metric method was returning a match when both m[:id] and metric.identifier were nil.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #207457 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports