Skip to content

Introduce PipelineTestReportsFinder class

Max Orefice requested to merge mo-add-pipeline-reports-finder into master

Part of #202114 (closed)

What does this MR do?

This MR introduces PipelineTestReportsFinder.

Why do we need this?

As @dosuken123 mentioned !27243 (diffs, comment 306091559), a Finder is being used to filter out the data before it gets sent to our Serializer.

Basically Serializer and Entity are for composing hash/json from a given items. In the most cases, items are properly filtered before it's passed to Serializer (That's the reason we have Finder before we pass the entities to Serializer in many places

Why are we adding this?

Today's problem

It's not currently possible to filter out our TestReport. We are working on making possible to link a screenshot for a given test failure.

Today, if a failure happens we need to inspect the job artifacts manually which takes time and it's a hard task for us internally.

Solution

We want to make it simple for the user to display a screenshot associated to a test failure. This way we can show a failing screenshot on a pipeline without browsing all the job artifacts manually.

Check the design for this feature.

Impact

This change should not have any impact on our current architecture as the backend response will remain unchanged.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports