Give feedback when using quick actions that have no effect
requested to merge tudelft-software-architecture-2020/gitlab:notes_quick_action_feedback into master
What does this MR do?
Give the user feedback when a user tries to perform a quick action that is not available. Previously, if you typed /close
in a closed issue, there is no feedback. Now it correctly displays the error as follows:
issue: #28927 (closed)
Screenshots
Performing an action that has no effect.
Performing an action that has no effect and an action that does have an effect, to be made prettier in a later MR, see discussion
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team