Skip to content

Fix delete action bug on CI Variable Modal

Payton Burdette requested to merge fix-ci-delete-variable-bug into master

What does this MR do?

Fixes bug where the modal close icon triggers a secondary action as well. This bug traces back to gitlab-ui. Updates specs to reflect changes of using modal-footer slot now.

Turns the new_variables_ui feature flag back to default true.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports