Geo Replication - Refactor action_spec
What does this MR do?
Closes #211400 (closed)
Currently, the axios related tests were catching any network request and then inspecting the callHistory to determine if the correct endpoint was called.
This was actually backwards, and we can mock only explicit endpoints with mockAxios and then by only mocking the ones we are testing can derive that they were called that way.
Thank you @markrian for the suggestion!
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #211400 (closed)