Skip to content

Move the vuex logic out of the filter component

Sam Beckham requested to merge 210334-refactor-vulnerability-filters into master

What does this MR do?

This refactor does a few things:

It moves all the Vuex logic out of the <filter> component used on the security dashboards. Some of this functionality has been pulled into the component as computed properties. The rest of it, has been moved up to the <filters> component.

As a result of this, there's some redundant getters that have been removed.

The <filters> spec has been migrated to Jest with some extra testing.

It even introduces the fancy new <gl-sprintf> component into the mix.

If all goes well, no one will ever notice these wonderful changes. Everything should continue as normal.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Closes #210334 (closed)

Edited by Sam Beckham

Merge request reports