Skip to content

Refactor AuditLogFinder public interface

Tan Le requested to merge tancnle/refactor-audit-log-finder into master

What does this MR do?

Split ID finding out of common execute interface.

AuditLogFinder now relies on methods provided by FinderMethods module to perform ID lookup. This ensures a consistent return type for execute (i.e always return AuditEvent::ActiveRecord_Relation) instead of AuditEvent::ActiveRecord_Relation and AuditEvent (if id is provided).

This MR also ensure both Group Audit Events and Audit Events API use the newly exposed find_by! method in AuditLogFinder.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports