WIP: Fix bridge status update race conditions
What does this MR do?
Related to #207234 (closed)
In CreateCrossProjectPipelineService
we update the bridge immediately after creating the downstream pipeline.
However, concurrently we have a after_transition
blocks in Ci::Pipeline
that update the bridge when a pipeline transitions to completed states.
If a downstream pipeline fails immediately because of some syntax errors, we have:
-
Ci::CreateCrossProjectPipelineService
drops the bridge because of downstream pipeline errors - The pipeline transition to
failed
also triggers aCi::PipelineBridgeStatusWorker
which also tries to drop the bridge
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team